-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): upgrade sigs.k8s.io/controller-tools to v0.14.0 #63
Conversation
Signed-off-by: Justen Stall <justenstall@gmail.com>
💚 CLA has been signed |
Confirming the fix works, tried it in quite a few of our repos (all of which were broken due to go1.22 -> controller-gen@v0.14 migration). Would be nice to merge soon. 😇 |
@tenstad Can you get help get this merged? |
Strange diff indeed! Appears empty lines within comments is parsed differently now: tenstad@95519bd |
Pulled your changes and verified tests locally, should be good to go now. Thanks for the help! |
In asciidoc, add hard line breaks (+) only for non-empty lines. In markdown, add only one hard line break (</br>).
@thbkrkr Should I pull your changes into this PR or open a PR for the |
@justenstall You could pull my changes but as you prefer. |
… update-controller-tools Signed-off-by: Justen Stall <justenstall@gmail.com>
This comment was marked as resolved.
This comment was marked as resolved.
@thbkrkr That logic makes sense to me, I'll add the change to this PR. |
Signed-off-by: Justen Stall <justenstall@gmail.com>
when will this merged? |
Thank you for the contribution! |
This updates
sigs.k8s.io/controller-tools
tov0.14.0
.With this new version the rendering of multi lines and empty lines has changed a little. The asciidoc and markdown rendering engines are therefore updated to take this into account.
Closes #62